[
https://issues.apache.org/jira/browse/CLOUDSTACK-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279484#comment-15279484
]
ASF subversion and git services commented on CLOUDSTACK-9374:
-------------------------------------------------------------
Commit 10bcf2955a436104bba96517dff9ce41ae2af7b7 in cloudstack's branch
refs/heads/master from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=10bcf29 ]
Merge pull request #1529 from mike-tutkowski/marvin_replace_sleep
Marvin: Replace a timer.sleep(30) with pulling
logichttps://issues.apache.org/jira/browse/CLOUDSTACK-9374
>From the ticket:
In the base.py file, there is a Host class with a delete instance method.
This method first attempts to transition the host into the maintenance resource
state.
The first step in this process is to transition the host into the
prepare-for-maintenance resource state.
A while later, the host can be transitioned completely into the maintenance
resource state.
In an attempt to wait for this transition to occur, the delete method has a
timer.sleep(30) call.
The hope is that the host will have transitioned from the
prepare-for-maintenance resource state to the maintenance resource state within
30 seconds, but this does not always happen.
We should correct this problem by putting in logic to query the management
server for the resource state of the host. If it's in the expected state, move
on; else, sleep for a bit and try again (up to a certain limit).
* pr/1529:
Replace a timer.sleep(30) with pulling logic
Signed-off-by: Will Stevens <[email protected]>
> Replace timer.sleep in host-delete method to correct timing problem
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-9374
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9374
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: marvin
> Affects Versions: 4.9.0
> Environment: N/A
> Reporter: Mike Tutkowski
> Assignee: Mike Tutkowski
> Fix For: 4.9.0
>
>
> In the base.py file, there is a Host class with a delete instance method.
> This method first attempts to transition the host into the maintenance
> resource state.
> The first step in this process is to transition the host into the
> prepare-for-maintenance resource state.
> A while later, the host can be transitioned completely into the maintenance
> resource state.
> In an attempt to wait for this transition to occur, the delete method has a
> timer.sleep(30) call.
> The hope is that the host will have transitioned from the
> prepare-for-maintenance resource state to the maintenance resource state
> within 30 seconds, but this does not always happen.
> We should correct this problem by putting in logic to query the management
> server for the resource state of the host. If it's in the expected state,
> move on; else, sleep for a bit and try again (up to a certain limit).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
