[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303767#comment-15303767
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9238:
--------------------------------------------

Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1567#discussion_r64875174
  
    --- Diff: setup/db/db/schema-471to480.sql ---
    @@ -27,3 +27,4 @@ ALTER TABLE `cloud`.`image_store` MODIFY COLUMN `url` 
varchar(2048);
     ALTER TABLE `cloud`.`template_store_ref` MODIFY COLUMN `url` varchar(2048);
     ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `url` varchar(2048);
     ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `download_url` 
varchar(2048);
    +ALTER TABLE `cloud`.`upload` MODIFY COLUMN `url` varchar(2048);
    --- End diff --
    
    I think this table isnt used anymore. 


> URL fields in database are to small. Cause malformed URLs
> ---------------------------------------------------------
>
>                 Key: CLOUDSTACK-9238
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0, 4.7.0, 4.8.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>              Labels: s3, template, templates, url, urls
>             Fix For: 4.8.0
>
>
> In for example the 'volume_store_ref' table the 'download_url' field is a 
> VARCHAR(255).
> This is to short for URLs. Same goes for the 'object_datastore_ref' table and 
> the 'url' field.
> With pre-signed S3 URLs this will cause issues.
> The fix would be to change the database fields to a VARCHAR(2048). No 
> code-change is required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to