[
https://issues.apache.org/jira/browse/CLOUDSTACK-9399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324610#comment-15324610
]
ASF GitHub Bot commented on CLOUDSTACK-9399:
--------------------------------------------
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
This fixes a bug in the current master right? I suspect this is a
candidate to be merged into the frozen master to be released in 4.9?
Please close and reopen this PR or force push to kick off Travis again, it
timed out.
Can I get one more code review? Thx...
> NullPointerException when deleting Host
> ---------------------------------------
>
> Key: CLOUDSTACK-9399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9399
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, Network Controller
> Reporter: Mani Prashanth Varma Manthena
> Assignee: Nick Livens
> Fix For: 4.9.0
>
>
> Nuage VSP : NullPointerException while deleting Nuage Vsp Device
> Here is the exception:
> {noformat}
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 DEBUG
> [c.c.r.ResourceManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116
> ctx-ed68901a) (logid:d5f86638) Dispatching resource state event DELETE_HOST
> to BaremetalDhcpManagerImpl
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 DEBUG
> [c.c.r.ResourceManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116
> ctx-ed68901a) (logid:d5f86638) Dispatching resource state event DELETE_HOST
> to NetworkUsageManagerImpl
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 DEBUG
> [c.c.r.ResourceManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116
> ctx-ed68901a) (logid:d5f86638) Dispatching resource state event DELETE_HOST
> to Ovs
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,494 ERROR
> [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Unexpected exception while executing
> com.cloud.api.commands.DeleteNuageVspDeviceCmd
> May 31 11:48:19 csc-1 management-server.log: java.lang.NullPointerException
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.cloud.resource.ResourceManagerImpl.doDeleteHost(ResourceManagerImpl.java:850)
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.cloud.resource.ResourceManagerImpl.deleteHost(ResourceManagerImpl.java:946)
> May 31 11:48:19 csc-1 management-server.log: #011at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> May 31 11:48:19 csc-1 management-server.log: #011at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> May 31 11:48:19 csc-1 management-server.log: #011at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> May 31 11:48:19 csc-1 management-server.log: #011at
> java.lang.reflect.Method.invoke(Method.java:606)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.sun.proxy.$Proxy161.deleteHost(Unknown Source)
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.cloud.network.manager.NuageVspManagerImpl.deleteNuageVspDevice(NuageVspManagerImpl.java:533)
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.cloud.api.commands.DeleteNuageVspDeviceCmd.execute(DeleteNuageVspDeviceCmd.java:75)
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
> May 31 11:48:19 csc-1 management-server.log: #011at
> com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:554)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> May 31 11:48:19 csc-1 management-server.log: #011at
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:502)
> May 31 11:48:19 csc-1 management-server.log: #011at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> May 31 11:48:19 csc-1 management-server.log: #011at
> java.util.concurrent.FutureTask.run(FutureTask.java:262)
> May 31 11:48:19 csc-1 management-server.log: #011at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> May 31 11:48:19 csc-1 management-server.log: #011at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> May 31 11:48:19 csc-1 management-server.log: #011at
> java.lang.Thread.run(Thread.java:745)
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,496 DEBUG
> [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Complete async job-116, jobStatus: FAILED, resultCode: 530,
> result:
> org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":530}
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,498 DEBUG
> [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Publish async job-116 complete on message bus
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,498 DEBUG
> [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Wake up jobs related to job-116
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,498 DEBUG
> [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Update db status for job-116
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,500 DEBUG
> [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Wake up jobs joined with job-116 and disjoin all subjobs
> created from job- 116
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,505 DEBUG
> [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Done executing
> com.cloud.api.commands.DeleteNuageVspDeviceCmd for job-116
> May 31 11:48:19 csc-1 management-server.log: 2016-05-31 11:48:19,505 INFO
> [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-76:ctx-80e26bc5 job-116)
> (logid:d5f86638) Remove job-116 from job monitoring
> May 31 11:48:21 csc-1 management-server.log: 2016-05-31 11:48:21,119 DEBUG
> [c.c.a.ApiServlet] (catalina-exec-19:ctx-43e00b8a) (logid:2c035630)
> ===START=== 0:0:0:0:0:0:0:1 -- GET
> signatureversion=3&apiKey=StjgrAiYEguhhZwogkx4SggkPhImhdxgSrDbfUZhLjL4As6bm4Xec8GC7WKFWuZXJmTAIl9zx_Qeh767T_yfpQ&expires=2016-05-31T18%3A58%3A21%2B0000&jobid=d5f86638-e270-4718-83fa-ff9a19ecf111&command=queryAsyncJobResult&signature=hhCmPvlhtDlFkR2XLvzm2OCs5%2BI%3D&response=json
> May 31 11:48:21 csc-1 management-server.log: 2016-05-31 11:48:21,122 DEBUG
> [o.s.b.f.a.InjectionMetadata] (catalina-exec-19:ctx-43e00b8a ctx-037d0e9e
> ctx-b3bda2da) (logid:2c035630) Processing injected element of bean
> 'org.apache.cloudstack.api.command.user.job.QueryAsyncJobResultCmd':
> AutowiredFieldElement for public com.cloud.configuration.ConfigurationService
> org.apache.cloudstack.api.BaseCmd._configService
> May 31 11:48:21 csc-1 management-server.log: 2016-05-31 11:48:21,123 DEBUG
> [o.s.b.f.s.DefaultListableBeanFactory] (catalina-exec-19:ctx-43e00b8a
> ctx-037d0e9e ctx-b3bda2da) (logid:2c035630) Returning cached instance of
> singleton bean 'configurationManagerImpl'
> {noformat}
> PR contents:
> 1) Fix for this bug
> 2) Marvin test coverage for Nuage VSP device CRUD operations including
> verifications for this bug fix.
> PEP8 & PyFlakes compliance of the added Marvin code:
> CloudStack$
> CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
> CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
> CloudStack$
> Marvin Test Run:
> CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg
> /test/integration/plugins/nuagevsp/test_nuage_vsp.py
> Marvin Test Results:
> Test Nuage VSP SDN plugin with basic Isolated Network functionality ... ===
> TestName: test_nuage_vsp | Status : SUCCESS ===
> ok
> Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName:
> test_nuage_vsp_device | Status : SUCCESS ===
> ok
> Ran 2 tests in 447.773s
> OK
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
