[
https://issues.apache.org/jira/browse/CLOUDSTACK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336899#comment-15336899
]
ASF GitHub Bot commented on CLOUDSTACK-9407:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67572107
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long
callerUserId, Account caller) {
}
}
+ /**
+ * Release network resources, it was done on vm stop previously.
+ * @param id vm id
+ * @throws ConcurrentOperationException
+ * @throws ResourceUnavailableException
+ */
+ private void releaseNetworkResourcesOnExpunge(long id) throws
ConcurrentOperationException, ResourceUnavailableException {
+ final VMInstanceVO vmInstance = _vmDao.findById(id);
--- End diff --
It is possible for ``_vmDao.findById`` to return ``null``. Please handling
for that case.
> vm_network_map table doesnt get cleaned up properly
> ---------------------------------------------------
>
> Key: CLOUDSTACK-9407
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9407
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.9.0
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
> Fix For: 4.9.0
>
>
> h3. Introduction
> It was found out that in production environments {{vm_network_map}} table
> entries were slowly growing. It was investigated how this entries were
> cleaned up.
> h3. Behaviour
> On vm creation, vm mappings are inserted on {{vm_network_map}}.
> On vm stop, mappings are deleted from {{vm_network_map}} for vm, as a result
> of the release of its nics.
> h3. Problem
> If created vm is stopped from hypervisor side (at least on vSphere in which
> we tested it), when CloudStack realizes vm is stopped it doesn't clean up
> {{vm_network_table}}, and, as cleanup is made during vm stop, when vm is
> eventually destroyed and expunged it won't clean up their entries in that
> table.
> h3. Proposed solution
> We propose to move {{vm_network_map}} table cleanup to expunge command
> instead of stop command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
