AppChecker created CLOUDSTACK-9442:
--------------------------------------
Summary: The left and the right parts of the binary expression are
indetical
Key: CLOUDSTACK-9442
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9442
Project: CloudStack
Issue Type: Bug
Security Level: Public (Anyone can view this level - this is the default.)
Reporter: AppChecker
Priority: Minor
Hello.
1)
[framework/db/src/com/cloud/utils/db/EcInfo.java line
60|https://github.com/apache/cloudstack/blob/46a6530e7059aded3c061c2609a15c947d9a75d3/framework/db/src/com/cloud/utils/db/EcInfo.java#L60]
{code:title=EcInfo.java|borderStyle=solid}
} else if (Collection.class == Collection.class) {
{code}
Collection.class is compared with itself.
May by it should be:
{code:title=EcInfo.java|borderStyle=solid}
} else if (Collection.class == rawClazz) {
{code}
2)
[engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
line
1170|https://github.com/apache/cloudstack/blob/46a6530e7059aded3c061c2609a15c947d9a75d3/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L1170]
{code:title=NetworkOrchestrator.java|borderStyle=solid}
if (_networkModel.areServicesSupportedInNetwork(network.getId(),
Service.Firewall) &&
_networkModel.areServicesSupportedInNetwork(network.getId(), Service.Firewall)
{code}
_networkModel.areServicesSupportedInNetwork(network.getId(), Service.Firewall)
is checked twice.
These possible defects found by [static code analyzer
AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
