[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414076#comment-15414076 ]
ASF GitHub Bot commented on CLOUDSTACK-9451: -------------------------------------------- GitHub user nathanejohnson opened a pull request: https://github.com/apache/cloudstack/pull/1632 Honor the forced parameter for stopVirtualMachine api call CLOUDSTACK-9451 https://issues.apache.org/jira/browse/CLOUDSTACK-9451 You can merge this pull request into a Git repository by running: $ git pull https://github.com/myENA/cloudstack feature/honor_force_stop_vm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1632.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1632 ---- commit 8e8b511388df62eef9a5488677a57417c32d67db Author: Nathan Johnson <njohn...@ena.com> Date: 2016-08-09T19:16:00Z Honor the forced parameter for stopVirtualMachine api call CLOUDSTACK-9451 ---- > stopVirtualMachine ignores forced parameter > ------------------------------------------- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server > Affects Versions: 4.8.0, 4.9.0 > Reporter: Nathan Johnson > Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)