[
https://issues.apache.org/jira/browse/CLOUDSTACK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425955#comment-15425955
]
ASF GitHub Bot commented on CLOUDSTACK-9458:
--------------------------------------------
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1640#discussion_r75252604
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {
boolean fenced = false;
if (alive == null) {
- s_logger.debug("Fencing off VM that we don't know the
state of");
+ s_logger.debug("Fencing off VM " + vm + " that we
don't know the state of");
--- End diff --
Turning all of those log debug lines without a `if` statement to lambda
expressions when we require Java8 would be easier if there're not wrapped
within a `if`:
```
s_logger.debug(() -> "Fencing off VM " + vm + " that we don't know the
state of");
```
with
```
default void debug(Supplier<String> stringSupplier) {
if (isDebugEnabled()) {
debug(stringSupplier.get());
}
}
```
The concatenation will be only done when debug is enabled.
You're right, I turn it to `warn`.
> Some VMs are being stopped when agent is reconnecting
> -----------------------------------------------------
>
> Key: CLOUDSTACK-9458
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9458
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Marc-Aurèle Brothier
> Assignee: Marc-Aurèle Brothier
>
> If you loose the communication between the management server and one of the
> agent for a few minutes, even though HA mode is not active the
> HighAvailibilityManager kicks in and start to schedule vm restart. Those
> tasks are being inserted as async job in the DB and if the agent comes back
> online during the time the jobs are still in the async table, they are pushed
> to the agent and shuts down the VMs. Then since HA is not active, the VM are
> not restarted.
> The expected behavior in my opinion is that the VM should not be restarted at
> all if HA mode is not active on them, and let the agent update the VM state
> with the power report.
> The bug lies in
> {{HighAvailibilityManagerImpl.scheduleRestartForVmsOnHost(final HostVO host,
> boolean investigate)}}, PR will follow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
