[ https://issues.apache.org/jira/browse/CLOUDSTACK-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429968#comment-15429968 ]
ASF GitHub Bot commented on CLOUDSTACK-9453: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1639#discussion_r75611082 --- Diff: tools/marvin/marvin/sshClient.py --- @@ -146,9 +146,8 @@ def createConnection(self): if self.retryCnt == 0 or ret == SUCCESS: break if except_msg != '': - self.logger.\ - exception("SshClient: Exception under " - "createConnection: %s" % except_msg) + self.logger.debug("SshClient: Exception under " + "createConnection: %s while connecting to " % except_msg, self.host) self.retryCnt -= 1 time.sleep(self.delay) --- End diff -- Recognizing that this comment is beyond the scope of this PR, would it be possible to refactor lines 146-152 to use ``wait_for`` and a lambda? > Optimizing Marvin > ----------------- > > Key: CLOUDSTACK-9453 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9453 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin > Affects Versions: Future > Reporter: Abhinandan Prateek > Assignee: Abhinandan Prateek > Fix For: Future > > > Currently running all Marvin tests can take upto 4 days. The tests are not > optimized for nested cloud setup where most of the test automation runs. > There are some simple things that can be done to optimize the runs: > 1. Have smaller default template: If we install macchinina template by > default and use it where there is no specific dependency on OS, then it will > result in speeding up many of Marvin tests. > 2. Most of the tests have template names hard-coded. It will be a good idea > to allow some form of configuration so that test writers can use templates > that better suit their test scenario. > 3. Some test timeouts are unnecessary long and a failure can be deducted much > early on instead of undergoing several long timeouts. > 4. Ability to tune service offerings to better suit marvin environments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)