[
https://issues.apache.org/jira/browse/CLOUDSTACK-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432307#comment-15432307
]
ASF GitHub Bot commented on CLOUDSTACK-9317:
--------------------------------------------
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1623
Trillian test result (trillian-pr1623-38-vmware-55u3-cs48):
Test completed. 37 look ok, 12 have errors
Test | Result | Time
--- | --- | ---
test_createRegion | Success | 0.035
test_DeployVmAntiAffinityGroup_in_project | Success | 267.303
test_01_router_internal_basic | Success | 0.606
test_02_router_internal_adv | Success | 1.027
test_03_restart_network_cleanup | Success | 140.944
test_04_restart_network_wo_cleanup | Success | 5.607
test_05_router_basic | Success | 0.029
test_06_router_advanced | Success | 0.046
test_07_stop_router | Success | 25.243
test_08_start_router | Success | 120.828
test_09_reboot_router | Success | 130.835
test_DeployVmAntiAffinityGroup | Success | 196.684
test_01_scale_vm | Skipped | 66.441
test_deploy_vgpu_enabled_vm | Skipped | 0.004
test_deploy_vm_from_iso | Success | 843.661
test_01_sys_vm_start | Success | 0.148
test_02_sys_template_ready | Success | 0.099
test_00_deploy_vm_root_resize | Success | 6.498
test_01_deploy_vm_root_resize | Success | 6.235
test_02_deploy_vm_root_resize | Success | 6.266
test_deployvm_firstfit | Success | 206.520
test_deployvm_userconcentrated | Success | 121.187
test_deployvm_userdispersing | Success | 55.752
test_01_create_service_offering | Success | 0.108
test_02_edit_service_offering | Success | 0.094
test_03_delete_service_offering | Success | 0.045
test_04_change_offering_small | Success | 97.309
test_deployvm_userdata | Success | 161.303
test_deployvm_userdata_post | Success | 20.425
test_01_create_disk_offering | Success | 0.113
test_02_create_sparse_type_disk_offering | Success | 0.075
test_04_create_fat_type_disk_offering | Success | 0.076
test_02_edit_disk_offering | Success | 0.048
test_03_delete_disk_offering | Success | 0.042
test_01_snapshot_root_disk | Success | 222.219
test_UpdateConfigParamWithScope | Success | 0.165
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_01_list_sec_storage_vm | Success | 0.157
test_02_list_cpvm_vm | Success | 0.139
test_03_ssvm_internals | Success | 3.896
test_04_cpvm_internals | Success | 1.199
test_05_stop_ssvm | Success | 204.223
test_06_stop_cpvm | Success | 181.887
test_07_reboot_ssvm | Success | 158.813
test_08_reboot_cpvm | Success | 156.708
test_09_destroy_ssvm | Success | 233.966
test_10_destroy_cpvm | Success | 236.990
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 441.264
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 546.859
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 441.481
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 516.759
test_01_create_template | Success | 146.055
test_CreateTemplateWithDuplicateName | Success | 251.738
test_02_edit_template | Success | 90.149
test_03_delete_template | Success | 5.145
test_04_extract_template | Success | 10.191
test_05_template_permissions | Success | 0.040
test_06_copy_template | Skipped | 0.000
test_07_list_public_templates | Success | 0.025
test_08_list_system_templates | Success | 0.056
test_01_create_iso | Success | 66.332
test_02_edit_iso | Success | 0.126
test_03_delete_iso | Success | 95.195
test_04_extract_Iso | Success | 5.192
test_05_iso_permissions | Success | 0.048
test_06_copy_iso | Skipped | 0.000
test_07_list_default_iso | Success | 0.039
test_01_create_lb_rule_src_nat | Success | 187.843
test_02_create_lb_rule_non_nat | Success | 187.338
test_assign_and_removal_lb | Success | 133.652
login_test_saml_user | Success | 22.090
test_nic_secondaryip_add_remove | Success | 192.737
test_advZoneVirtualRouter | Success | 0.020
test_deploy_vm | Success | 0.018
test_deploy_vm_multiple | Success | 283.325
test_01_stop_vm | Success | 10.132
test_02_start_vm | Success | 20.214
test_03_reboot_vm | Success | 5.124
test_06_destroy_vm | Success | 5.108
test_07_restore_vm | Success | 0.102
test_08_migrate_vm | Success | 76.170
test_09_expunge_vm | Success | 125.236
test_10_attachAndDetach_iso | Success | 72.134
test_network_acl | Success | 201.902
test_delete_account | Success | 278.007
test_01_port_fwd_on_src_nat | Success | 111.800
test_02_port_fwd_on_non_src_nat | Success | 55.628
test_public_ip_admin_account | Success | 40.272
test_public_ip_user_account | Success | 10.259
test_reboot_router | Success | 625.125
test_releaseIP | Success | 238.215
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.311
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.609
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success |
66.731
test_01_test_vm_volume_snapshot | `Error` | 156.243
test_01_create_vm_snapshots | Success | 161.736
test_02_revert_vm_snapshots | Success | 194.222
test_03_delete_vm_snapshots | Success | 275.205
test_vm_nic_adapter_vmxnet3 | Skipped | 0.000
test_01_nic | Success | 868.217
test_01_create_volume | Success | 520.190
test_02_attach_volume | Success | 58.866
test_03_download_attached_volume | Success | 20.328
test_04_delete_attached_volume | Success | 15.258
test_05_detach_volume | Success | 100.311
test_06_download_detached_volume | Success | 60.581
test_07_resize_fail | Skipped | 10.258
test_08_resize_volume | Skipped | 10.193
test_09_delete_detached_volume | Success | 30.919
test_extendPhysicalNetworkVlan | `Error` | 0.022
test_UpdateStorageOverProvisioningFactor | Success | 0.123
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1213.876
test_02_redundant_VPC_default_routes | Success | 579.689
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers |
Success | 759.643
test_04_rvpc_network_garbage_collector_nics | Success | 865.118
test_05_rvpc_multi_tiers | Success | 662.118
test_isolate_network_password_server | `Failure` | 166.672
test_createPortablePublicIPAcquire | Success | 15.658
test_createPortablePublicIPRange | Success | 15.391
test_01_VPC_nics_after_destroy | Success | 637.734
test_02_VPC_default_routes | Success | 393.037
test_01_primary_storage_iscsi | Skipped | 0.028
test_01_primary_storage_nfs | Success | 38.355
test_01_vpc_privategw_acl | `Failure` | 101.960
test_02_vpc_privategw_static_routes | `Failure` | 207.667
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 242.957
test_04_rvpc_privategw_static_routes | `Failure` | 434.113
test_01_redundant_vpc_site2site_vpn | `Error` | 692.909
ContextSuite context=TestRVPCSite2SiteVpn>:teardown | `Error` | 698.010
test_01_vpc_remote_access_vpn | `Error` | 0.064
test_01_vpc_site2site_vpn | `Error` | 486.664
test_dedicatePublicIpRange | `Error` | 0.298
test_create_pvlan_network | Success | 5.216
test_01_quota | `Error` | 0.033
test_02_quota | `Error` | 0.029
test_03_quota | `Error` | 0.028
test_04_quota | `Error` | 0.029
test_05_quota | `Error` | 0.027
test_06_quota | `Error` | 0.032
test_07_quota | `Error` | 0.031
test_01_reset_vm_on_reboot | Success | 25.316
test_01_updatevolumedetail | Success | 0.122
test_router_dhcphosts | `Failure` | 166.785
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 187.075
test_02_routervm_iptables_policies | `Failure` | 231.410
test_01_single_VPC_iptables_policies | `Failure` | 371.973
test_01_isolate_network_FW_PF_default_routes_egress_true | Success | 258.519
test_02_isolate_network_FW_PF_default_routes_egress_false | Success |
268.553
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` |
410.379
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` |
361.440
test_03_RVR_Network_check_router_state | Success | 369.925
Trillian env - trillian-pr1623-38-vmware-55u3-cs48, Job ID 38
Hypervisor: vmware-55u3 (x2), Advanced Zone
Mgmt host os - 6
Marvin logs at:
http://packages.shapeblue.com/cloudstack/pr/1623/trillian/trillian-pr1623-38-vmware-55u3-cs48
> Disabling static NAT on many IPs can leave wrong IPs on the router
> ------------------------------------------------------------------
>
> Key: CLOUDSTACK-9317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9317
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, Virtual Router
> Affects Versions: 4.7.0, 4.7.1, 4.7.2
> Reporter: Jeff Hair
>
> The current behavior of enabling or disabling static NAT will call the apply
> IP associations method in the management server. The method is not
> thread-safe. If it's called from multiple threads, each thread will load up
> the list of public IPs in different states (add or revoke)--correct for the
> thread, but not correct overall. Depending on execution order on the virtual
> router, the router can end up with public IPs assigned to it that are not
> supposed to be on it anymore. When another account acquires the same IP, this
> of course leads to network problems.
> The problem has been in CS since at least 4.2, and likely affects all
> recently released versions. Affected version is set to 4.7.x because that's
> what we verified against.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
