[
https://issues.apache.org/jira/browse/CLOUDSTACK-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434911#comment-15434911
]
ASF GitHub Bot commented on CLOUDSTACK-9470:
--------------------------------------------
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1660
LGTM for the test.
Exception in network_acl_test **before the fix**
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//NB313W/results.txt
Test network ACL lists and items in VPC ... === TestName: test_network_acl
| Status : EXCEPTION ===
ERROR
======================================================================
ERROR: Test network ACL lists and items in VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/exclude/test_network_acl.py",
line 81, in test_network_acl
domainid=self.domain.id
File "/usr/local/lib/python2.7/site-packages/marvin/lib/base.py", line
4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File
"/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py",
line 2210, in createVPC
response = self.connection.marvinRequest(command,
response_type=response, method=method)
File
"/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line
379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created :
u'2016-08-24T05:52:23-0700', jobresult : {errorcode : 530, errortext : u'Failed
to create VPC'}, cmd :
u'org.apache.cloudstack.api.command.admin.vpc.CreateVPCCmdByAdmin', userid :
u'd557133a-3fcc-11e5-9c45-005056ad45b7', jobstatus : 2, jobid :
u'bc8fb5de-94de-43bf-befd-a2b450ab571c', jobresultcode : 530, jobresulttype :
u'object', jobinstancetype : u'None', accountid :
u'd556f1dc-3fcc-11e5-9c45-005056ad45b7'}
-------------------- >> begin captured stdout << ---------------------
=== TestName: test_network_acl | Status : EXCEPTION ===
--------------------- >> end captured stdout << ----------------------
..... (NOT INCLUDED)
-------------------- >> begin captured logging << --------------------
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 1 test in 115.185s
FAILED (errors=1)
**After fix is deployed:**
[root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt
Test network ACL lists and items in VPC ... === TestName: test_network_acl
| Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 211.968s
OK
> [BLOCKER] Fix for test_network_acl, SshHelper
> ---------------------------------------------
>
> Key: CLOUDSTACK-9470
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9470
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Affects Versions: 4.10.0
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
> Fix For: 4.10.0
>
>
> h2. Problem
> In a Vmware environment, running {{test_network_acl}} we examined why it was
> failing, it was discovered an issue on {{VmwareResource}}:
> {code:title=VmwareResource.java|borderStyle=solid}
> private int findRouterEthDeviceIndex(String domrName, String routerIp, String
> mac) throws Exception {
> VmwareManager mgr =
> getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
> s_logger.info("findRouterEthDeviceIndex. mac: " + mac);
> // TODO : this is a temporary very inefficient solution, will
> refactor it later
> Pair<Boolean, String> result = SshHelper.sshExecute(routerIp,
> DefaultDomRSshPort, "root", mgr.getSystemVMKeyFile(), null, "ls
> /proc/sys/net/ipv4/conf");
> {code}
> Command sent to router returned a pair which its first parameter was always
> true but second parameter sometimes it was null and sometimes the correct
> output for given command.
> h2. Solution
> Examining {{SshHelper}} we discovered that cases in which second parameter in
> result was null, didn't consume stdout properly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
