[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438731#comment-15438731
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9462:
--------------------------------------------

Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1647#discussion_r76393992
  
    --- Diff: packaging/systemd/cloudstack-agent.default ---
    @@ -0,0 +1,24 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +JAVA_HOME=/usr/lib/jvm/jre
    +if [ ! -f "$JAVA_HOME"/bin/java ] ; then
    +    JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    +fi
    --- End diff --
    
    Thanks @vincentbernat that's a nice idea. I've removed usage of JAVA_HOME, 
I checked and indeed all we want was path to java which I checked by default is 
at /usr/bin/java on most distros including the ones I tested - Ubuntu 12.04, 
14.04, 16.04 and on CentOS 7(.2). Are we good to merge with the new change?


> Systemd packaging for Ubuntu 16.04
> ----------------------------------
>
>                 Key: CLOUDSTACK-9462
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9462
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: 4.10.0, 4.9.1
>
>
> Support for building deb packages that will work on Ubuntu 16.04



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to