[ https://issues.apache.org/jira/browse/CLOUDSTACK-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448051#comment-15448051 ]
ASF GitHub Bot commented on CLOUDSTACK-9417: -------------------------------------------- Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r76731031 --- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java --- @@ -43,9 +43,9 @@ protected static final int DEFAULT_AGGREGATION_RANGE = 1440; protected StringBuilder errors; protected List<CheckCase> checkCases; - protected String lastCheckFile = "/usr/local/libexec/sanity-check-last-id"; + protected String lastCheckFile = "/var/cache/cloudstack/usage/sanity-check-last-id"; --- End diff -- Just a thought, why we store this in a file (on one of the mgmt/usage server hosts) and not in database? > Usage module refactoring > ------------------------ > > Key: CLOUDSTACK-9417 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9417 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Usage > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > Fix For: 4.9.1 > > > h3. Introduction > Usage sanity check file was not been updated on sanity check. > It is proposed: > * New usage folder {{/var/cache/cloudstack/usage}}, creation on > cloudstack-usage package built. > * New sanity check file location in new folder {{/var/cache/cloudstack/usage}} > * Timestamp included in {{usage.log}} file > * Include {{updateMaxId()}} on sanity check as it wasn't being updated -- This message was sent by Atlassian JIRA (v6.3.4#6332)