[
https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457123#comment-15457123
]
ASF GitHub Bot commented on CLOUDSTACK-9451:
--------------------------------------------
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1635
@nathanejohnson I want to get this bug fix into 4.8.2.0. In order to make
it, we need to complete the following:
* [] Resolve the question about the name of the method (``stop`` vs
``forcedStop``)
* [] Amend the commit message to summarize the change and explain the
reason/motivation for it
* [] Code review LGTM
* [] Test LGTM
@rhtyd or I will provide the code review LGTM once we resolve the naming
question. Do you have someone who can run the test? Also, is this change
something we can check via a Marvin test case?
> stopVirtualMachine ignores forced parameter
> -------------------------------------------
>
> Key: CLOUDSTACK-9451
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API, Management Server
> Affects Versions: 4.8.0, 4.9.0
> Reporter: Nathan Johnson
> Priority: Minor
>
> As reported by Jeff Hair from the mailing list:
> Hi,
> I'm looking at the documentation and then the code for stopVirtualMachine.
> The forced parameter is passed down into the VM manager, where it seems to
> be ignored. This means that cleanupEvenIfFailed during VM stop will always
> be false, despite what the API command says. Going back to commit a4f4c986
> in 2013, we can see that the forced parameter was used. During subsequent
> refactoring, this seems to have vanished.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)