[
https://issues.apache.org/jira/browse/CLOUDSTACK-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480485#comment-15480485
]
ASF subversion and git services commented on CLOUDSTACK-9470:
-------------------------------------------------------------
Commit bdb563e18b885772be76ac43583fb3d8041fcafa in cloudstack's branch
refs/heads/master from [~jburwell]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bdb563e ]
Merge release branch 4.9 to master
* 4.9:
CLOUDSTACK-9470: Fix for SshHelper - test_network_acl was failing on Vmware
due to a bug in sshExecute, in which value returned was null and there was
still stdout to consume. This fix addresses this problem, consuming stdout
peoperly to return expected value in sshExecute
> [BLOCKER] Bug in SshHelper affecting interaction with vRouter in
> VmwareResource and HypervDirectConnectResource
> ---------------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9470
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9470
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Affects Versions: 4.7.0, 4.8.0, 4.9.0
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
> Fix For: 4.10.0.0, 4.9.1.0
>
>
> h2. Problem
> In a Vmware environment, running {{test_network_acl}} we examined why it was
> failing, it was discovered an issue on {{VmwareResource}}:
> {code:title=VmwareResource.java|borderStyle=solid}
> private int findRouterEthDeviceIndex(String domrName, String routerIp, String
> mac) throws Exception {
> VmwareManager mgr =
> getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
> s_logger.info("findRouterEthDeviceIndex. mac: " + mac);
> // TODO : this is a temporary very inefficient solution, will
> refactor it later
> Pair<Boolean, String> result = SshHelper.sshExecute(routerIp,
> DefaultDomRSshPort, "root", mgr.getSystemVMKeyFile(), null, "ls
> /proc/sys/net/ipv4/conf");
> {code}
> Command sent to router returned a pair which its first parameter was always
> true but second parameter sometimes it was null and sometimes the correct
> output for given command.
> h2. Solution
> Examining {{SshHelper}} we discovered that cases in which second parameter in
> result was null, didn't consume stdout properly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
