[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488560#comment-15488560
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9379:
--------------------------------------------

Github user serg38 commented on the issue:

    https://github.com/apache/cloudstack/pull/1542
  
    @rhtyd @jburwell @rafaelweingartner @koushik-das The rationale to have 
vmware.nested.virtualization.perVM was that advanced vm_details and template 
details are user controlled. With 
https://issues.apache.org/jira/browse/CLOUDSTACK-9457
    ‘Allow retrieval and modification of VM and template details via API and 
UI’ users will be able to change any advanced details in UI and API.
    If admin wants to preserve that nested virtualization is controlled in 
centralized fashion they can do so by setting 
vmware.nested.virtualization.perVM to ‘false’. Idea was to allow organizations 
that currently have nested virtualization disabled to have it so after upgrade. 
Does it make sense or everyone prefers that setting on VM level overrides 
global one? 


> Support nested virtualization at VM level on VMware Hypervisor
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9379
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9379
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: VMware
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>             Fix For: 4.10.0.0
>
>
> h2. Introduction
> It is desired to support nested virtualization at VM level for VMware 
> hypervisor. Current behaviour supports enabling/desabling global nested 
> virtualization by modifying global config {{'vmware.nested.virtualization'}}. 
> It is wished to improve this feature, having control at VM level instead of a 
> global control only.
> h2. Proposal
> A new global configuration is added, to enable/disable VM nested 
> virtualization control: {{'vmware.nested.virtualization.perVM'}}. Default 
> value=false
> h2. Behaviour
> After a vm deployment or start command, vm params include 
> {{nestedVirtualizationFlag}} key and its value is:
> * true -> nested virtualization enabled
> * false -> nested virtualization disabled
> We will determinate nested virtualization enabled/disabled by examining:
> * (1) global configuration {{'vmware.nested.virtualization'}} value
> * (2) global configuration {{'vmware.nested.virtualization.perVM'}} value
> * (3) {{'nestedVirtualizationFlag'}} value in {{user_vm_details}} if present, 
> null if not.
> Using this 3 values, there are different use cases:
> # (1) = TRUE, (2) = TRUE, (3) is null -> ENABLED
> # (1) = TRUE, (2) = TRUE, (3) = TRUE -> ENABLED
> # (1) = TRUE, (2) = TRUE, (3) = FALSE -> DISABLED
> # (1) = TRUE, (2) = FALSE -> ENABLED
> # (1) = FALSE, (2) = TRUE, (3) is null -> DISABLED
> # (1) = FALSE, (2) = TRUE, (3) = TRUE -> ENABLED
> # (1) = FALSE, (2) = TRUE, (3) = FALSE -> DISABLED
> # (1) = FALSE, (2) = FALSE -> DISABLED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to