[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509338#comment-15509338
 ] 

ASF subversion and git services commented on CLOUDSTACK-9495:
-------------------------------------------------------------

Commit a43abbe47bb88bd6dd727e84a8aa2977fee114ee in cloudstack's branch 
refs/heads/4.9 from [~muralireddy]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a43abbe ]

fix egress rule incorrect behavior

CLOUDSTACK-9480: Egress Firewall: Incorrect use of Allow/Deny for ICMP

     fix ensures, ICMP, TCP, UDP are handled similalry w.r.t egress rule action

CLOUDSTACK-9495: Egress rules functionalty broken when protocol=all specified

     when protocol=all specified, CIDR was ignored. Fix ensures if CIDR is 
specified
     its always used in configuring iptable rules

 2 new test cased to test /32 CIDR


> Egress rules functionalty broken when protocol=all specified
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9495
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9495
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>            Reporter: Murali Reddy
>            Assignee: Murali Reddy
>            Priority: Critical
>             Fix For: 4.10.0.0, 4.9.1.0, 4.8.2.0
>
>
> Egress rules handling in 
> systemvm/patches/debian/config/opt/cloud/bin/configure.py, class CsAcl, 
> add_rule() has below logic for handling protocol
> {code}
> if rule['protocol'] != "all":
>    fwr += " -s %s " % cidr + \
>    " -p %s " % rule['protocol'] + \
>    " -m %s " % rule['protocol'] + \
>    " --dport %s" % rnge
> {code}
> There is no else block to handle case when protocol in 'all' in which case 
> CIDR never gets passed to the iptables command, hence resulting in accept all 
> rule FW_EGRESS_RULES chain.
> To reproduce the issue just give any cidr in the guest subnet, for e.g. 
> 10.1.1.27/31 and protocol all and see the result in FW_EGRESS_RULES of the 
> filter table, you will see accept all rule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to