[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510825#comment-15510825
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:
--------------------------------------------

Github user serg38 commented on the issue:

    https://github.com/apache/cloudstack/pull/871
  
    @jburwell @rhtyd @karuturi @nvazquez I assume the current code doesn’t 
allow volume snapshots on the top of vmsnapshots on purpose. In that case is it 
best to revert PR871 or create a new PR to address the Marvin script?
    
    From: Nicolas Vazquez <notificati...@github.com>
    Reply-To: apache/cloudstack <re...@reply.github.com>
    Date: Wednesday, September 21, 2016 at 11:15 AM
    To: apache/cloudstack <cloudst...@noreply.github.com>
    Cc: Sergey Levitskiy <sergey.levits...@autodesk.com>, Mention 
<ment...@noreply.github.com>
    Subject: Re: [apache/cloudstack] CLOUDSTACK-8893: Fixing script as per the 
latest functionality (#871)
    
    
    Hi @sanju1010<https://github.com/sanju1010>,
    
    @serg38<https://github.com/serg38> and I are working on this PR 
#1677<https://github.com/apache/cloudstack/pull/1677> which solves vm snapshot 
creation issue. After running test_vm_snapshots.py we're getting exception on 
test_01_test_vm_volume_snapshot as it was expected before your changes in this 
PR.
    
    We're getting: 'CloudstackAPIException: Execute cmd: createsnapshot failed, 
due to: errorCode: 431, errorText:Volume snapshot is not allowed, please detach 
it from VM with VM Snapshots\n']
    
    This is consistent with VolumeApiServiceImpl.allocSnapshot method, in which 
it is:
    
            if (volume.getInstanceId() != null) {
    
                // Check that Vm to which this volume is attached does not have 
VM Snapshots
    
                if (_vmSnapshotDao.findByVm(volume.getInstanceId()).size() > 0) 
{
    
                    throw new InvalidParameterValueException("Volume snapshot 
is not allowed, please detach it from VM with VM Snapshots");
    
                }
    
            }
    
    Do you want us to adapt test_vm_snapshots.py in mentioned PR to support 
this or would you like to address it yourself?
    
    Thanks
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/cloudstack/pull/871#issuecomment-248696674>, 
or mute the 
thread<https://github.com/notifications/unsubscribe-auth/APbWPq2NlxyRQADHpD6ucL5jzTkZ_Zy1ks5qsXQpgaJpZM4GBeLo>.



> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8893
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Automation
>    Affects Versions: 4.6.0
>            Reporter: Sanjeev N
>            Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to