[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515417#comment-15515417
 ] 

Abhinandan Prateek edited comment on CLOUDSTACK-9489 at 9/23/16 5:08 AM:
-------------------------------------------------------------------------

I think yes there is an issue. Thanks [~pdion] for sharing the upgrade diff. 
This helped me nail the issue.

There are these following variables added to Config.java in 4.6:

   // Ovm
    OvmPublicNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.public.network.device", null, "Specify the public bridge on host for 
public network", null),
    OvmPrivateNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.private.network.device", null, "Specify the private bridge on host for 
private network", null),
    OvmGuestNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.guest.network.device", null, "Specify the private bridge on host for 
private network", null),

    // Ovm3
    Ovm3PublicNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.public.network.device", null, "Specify the public bridge on host for 
public network", null),
    Ovm3PrivateNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.private.network.device", null, "Specify the private bridge on host for 
private network", null),
    Ovm3GuestNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.guest.network.device", null, "Specify the guest bridge on host for guest 
network", null),
    Ovm3StorageNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.storage.network.device", null, "Specify the storage bridge on host for 
storage network", null),
    Ovm3HeartBeatTimeout(
            "Advanced",
            ManagementServer.class,
            Integer.class,
            "ovm3.heartbeat.timeout",
            "120",
            "timeout used for primary storage check, upon timeout a panic is 
triggered.",
            null),
    Ovm3HeartBeatInterval(
            "Advanced",
            ManagementServer.class,
            Integer.class,
            "ovm3.heartbeat.interval",
            "1",
            "interval used to check primary storage availability.",
            null),


Only two have default values the rest have default value as NULL. The db values 
are only created for those config variables whose default value is not NULL.

ie: ovm3.heartbeat.interval, ovm3.heartbeat.timeout are in configuration table 
while the ones noted by Luc are missing:
                   
ovm3.guest.network.device                      
ovm3.private.network.device                    
ovm3.public.network.device                     
ovm3.storage.network.device   






was (Author: aprateek):
I think yes there is an issue. Thanks [~pdion] for sharing the upgrade diff. 
This helped me nail the issue.

There are these following variables added to Config.java in 4.6:

   // Ovm
    OvmPublicNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.public.network.device", null, "Specify the public bridge on host for 
public network", null),
    OvmPrivateNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.private.network.device", null, "Specify the private bridge on host for 
private network", null),
    OvmGuestNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.guest.network.device", null, "Specify the private bridge on host for 
private network", null),

    // Ovm3
    Ovm3PublicNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.public.network.device", null, "Specify the public bridge on host for 
public network", null),
    Ovm3PrivateNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.private.network.device", null, "Specify the private bridge on host for 
private network", null),
    Ovm3GuestNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.guest.network.device", null, "Specify the guest bridge on host for guest 
network", null),
    Ovm3StorageNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.storage.network.device", null, "Specify the storage bridge on host for 
storage network", null),
    Ovm3HeartBeatTimeout(
            "Advanced",
            ManagementServer.class,
            Integer.class,
            "ovm3.heartbeat.timeout",
            "120",
            "timeout used for primary storage check, upon timeout a panic is 
triggered.",
            null),
    Ovm3HeartBeatInterval(
            "Advanced",
            ManagementServer.class,
            Integer.class,
            "ovm3.heartbeat.interval",
            "1",
            "interval used to check primary storage availability.",
            null),


Only two have default values the rest have default value as NULL. The db values 
are only created for those config variables whose default value is not NULL.

ie: ovm3.heartbeat.interval, ovm3.heartbeat.timeout are in configuration table 
while the ones noted by Luc are missing:
                   
ovm3.guest.network.device                      
ovm3.private.network.device                    
ovm3.public.network.device                     
ovm3.storage.network.device   





> When upgrading, Config.java new configuration are not updated.
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9489
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>            Reporter: Pierre-Luc Dion
>            Assignee: Pierre-Luc Dion
>            Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to