[ https://issues.apache.org/jira/browse/CLOUDSTACK-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526412#comment-15526412 ]
ASF GitHub Bot commented on CLOUDSTACK-9509: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1694#discussion_r80714972 --- Diff: server/src/com/cloud/storage/listener/StoragePoolMonitor.java --- @@ -99,12 +99,12 @@ public void processConnect(Host host, StartupCommand cmd, boolean forRebalance) } Long hostId = host.getId(); - s_logger.debug("Host " + hostId + " connected, sending down storage pool information ..."); + s_logger.debug("Host " + hostId + " connected, connecting host to shared pool id " + pool.getId() + " and sending storage pool information ..."); --- End diff -- Please wrap in a `if (s_logger.isDebugEnabled)` to check to avoid unnecessary string concatenation when the `DEBUG` level is disabled. > KVM Hosts connect with no storage > --------------------------------- > > Key: CLOUDSTACK-9509 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9509 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Priority: Critical > Fix For: 4.8.1, 4.10.0.0, 4.9.1.0 > > > KVM hosts on shared storage failure was accepted by mgmt server with the > host state as Up, even though there was no primary/shared storage available > on it. They fail the ModifyStoragePoolCommand, but the management server > continues on with adding SSH keys and marking them as up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)