[
https://issues.apache.org/jira/browse/CLOUDSTACK-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602313#comment-15602313
]
ASF GitHub Bot commented on CLOUDSTACK-4858:
--------------------------------------------
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1697#discussion_r84712741
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -374,8 +375,24 @@ public SnapshotInfo takeSnapshot(SnapshotInfo
snapshot) {
snapshot = result.getSnashot();
DataStore primaryStore = snapshot.getDataStore();
+ boolean backupFlag =
Boolean.parseBoolean(configDao.getValue(Config.BackupSnapshotAfterTakingSnapshot.toString()));
--- End diff --
@nathanejohnson in #1600 I've added a flag to the create snapshot API
called `locationType` which can take `primary` or `secondary` as the parameter.
We could use that here as well. Although for this PR, a global would suffice
> Disable copy snapshot to secondary storage snapshot.backup.rightafter
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-4858
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4858
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.2.0
> Environment: kvm, rbd
> Reporter: Sebastian Igerl
>
> "snapshot.backup.rightafterbackup" is set to false but still the snapshot is
> copied to secondary storage.
> Primary storage is Ceph/RDB, Secondary is NFS. I restarted both the
> management server and the nodes.
> see :
> http://www.marshut.com/wpviz/disable-copy-snapshot-to-secondary-storage-in-cs-4-2.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
