[ https://issues.apache.org/jira/browse/CLOUDSTACK-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604933#comment-15604933 ]
ASF subversion and git services commented on CLOUDSTACK-9319: ------------------------------------------------------------- Commit 99bb50072def07769d26440b269c7668ac12ee2c in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=99bb500 ] Merge pull request #1451 from insom/CLOUDSTACK-9319 CLOUDSTACK-9319: Use timeout when applying config to virtual routerFrom the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9319): > The timeout parameter is not passed down to `applyConfigToVR` inside > `VirtualRoutingResource` in all cases. > > This timeout is worked out as 3 seconds per command or 120 seconds (whichever > is larger), but because it's not passed to the first invocation, the default > (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT) is used. > > In a recent upgrade of our Virtual Routers, the timeout was being hit and > increasing `router.aggregation.command.each.timeout` had no effect. I built a > custom 4.8 agent with the timeout increased to allow the upgrade to continue. * pr/1451: Remove dangerous prototype of applyConfigToVR Use timeout when applying config to virtual router Signed-off-by: Rajani Karuturi <rajani.karut...@accelerite.com> > Timeout is not passed to virtual router operations consistently > --------------------------------------------------------------- > > Key: CLOUDSTACK-9319 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9319 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router > Affects Versions: 4.8.0 > Environment: KVM + Ceph cloud, Ubuntu hosts. > Reporter: Aaron Brady > Priority: Trivial > > The timeout parameter is not passed down to `applyConfigToVR` inside > `VirtualRoutingResource` in all cases. > This timeout is worked out as 3 seconds per command or 120 seconds (whichever > is larger), but because it's not passed to the first invocation, the default > (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT) is used. > In a recent upgrade of our Virtual Routers, the timeout was being hit and > increasing `router.aggregation.command.each.timeout` had no effect. I built a > custom 4.8 agent with the timeout increased to allow the upgrade to continue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)