[
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665315#comment-15665315
]
ASF GitHub Bot commented on CLOUDSTACK-9572:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1740#discussion_r87913578
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -1111,6 +1111,20 @@ public boolean canOperateOnVolume(Volume volume) {
}
@Override
+ public void cleanupSnapshotsByVolume(Long volumeId) {
+ List<SnapshotVO> volSnapShots =
_snapshotDao.listByVolumeId(volumeId);
+ for(SnapshotVO snapshot: volSnapShots) {
+ SnapshotInfo info =
snapshotFactory.getSnapshot(snapshot.getId(), DataStoreRole.Primary);
--- End diff --
This appears to be an application side join. Please consider creating a
new query to retrieve all snapshot info instances associated with `volumeId` to
reduce load on the database and simplify this method.
> Snapshot on primary storage not cleaned up after Storage migration
> ------------------------------------------------------------------
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Affects Versions: 4.8.0
> Environment: Xen Server
> Reporter: subhash yedugundla
> Fix For: 4.8.1
>
>
> Issue Description
> ===============
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local
> storage and is transferring this snapshot to secondary storage. But the
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and
> is staying on local storage. So local storage will fill up with unneeded
> snapshots.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
