[ https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672513#comment-15672513 ]
ASF GitHub Bot commented on CLOUDSTACK-8715: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1545#discussion_r88378451 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -776,6 +779,13 @@ public boolean configure(final String name, final Map<String, Object> params) th _localStoragePath = "/var/lib/libvirt/images/"; } + /* Directory to use for Qemu sockets like for the Qemu Guest Agent */ + _qemuSocketsPath = new File("/var/lib/libvirt/qemu"); + String _qemuSocketsPathVar = (String)params.get("qemu.sockets.path"); + if (!StringUtils.isNotBlank(_qemuSocketsPathVar)) { --- End diff -- Minor not: A logical not perform on `StringUtils.isNotBlank` is a awkward. Please consider refactoring to `if (StringUtils.isBlank(_qemuSocketsPathVar)`. > Add support for qemu-guest-agent to libvirt provider > ---------------------------------------------------- > > Key: CLOUDSTACK-8715 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM > Reporter: Sten Spans > Assignee: Wido den Hollander > Labels: kvm, libvirt, qemu, systemvm > Fix For: Future > > > The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite > a lot of useful functionality, which can only be provided by having an agent > on the VM. This includes things like freezing/thawing filesystems (for > backups), reading files on the guest, listing interfaces / ip addresses, etc. > This feature has been requested by users, but is currently not implemented. > http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent > The first change needed is to add the following to the XML generated for KVM > virtual machines,: > <channel type='unix'> > <source mode='bind'/> > <target type='virtio' name='org.qemu.guest_agent.0'/> > </channel> > This provides the communication channel between libvirt and the agent on the > host. All in all a pretty simple change to LibvirtComputingResource.java / > LibvirtVMDef.java > Secondly the qemu-guest-agent package needs to be added to the systemvm > template. -- This message was sent by Atlassian JIRA (v6.3.4#6332)