[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672830#comment-15672830
 ] 

ASF subversion and git services commented on CLOUDSTACK-9071:
-------------------------------------------------------------

Commit c1997a1705278d4ba39d64102e7ce76894f1e30d in cloudstack's branch 
refs/heads/4.8 from [~widodh]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c1997a1 ]

CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector

Both host and path could have been NULL which causes the StatsCollector
no to start properly.

By checking if the Strings are not Empty or Null we make sure the StatsCollector
always runs and does not prevent the Management Server from starting.

Signed-off-by: Wido den Hollander <w...@widodh.nl>

Conflicts:
        server/src/com/cloud/server/StatsCollector.java


> stats.output.uri stops the server from starting if the uri is malformed
> -----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9071
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9071
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.0
>            Reporter: Carles Figuerola
>
> After inputting a malformed uri (was missing the graphite://) and restarting 
> the management service, the application stops at:
> 2015-11-17 11:06:42,861 INFO  [c.c.s.StatsCollector] 
> (localhost-startStop-1:null) metrics.dev.company.net is not a valid protocol 
> for external statistics. No statistics will be send.
> No more logs are output and tomcat is up but serving a completely blank page.
> When the uri has this form: (graphite://metrics.dev.company.net:2013), the 
> end result is very similar to the previous one
> (also, the last word should be "sent")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to