[
https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728324#comment-15728324
]
ASF GitHub Bot commented on CLOUDSTACK-9633:
--------------------------------------------
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed @swill the change is good. What needs to be considered is what
happens with old snapshots, from a older version upgraded to this version, that
are without the .vhd extension. If it can be checked that in a upgraded version
where the older snapshots are without .vhd extension and new ones with .vhd
extension, that cloudstack operations will work fine. Otherwise during upgrade
we need to add .vhd to older snapshots for Xen.
Another thing is that the marvin tests still assume that there is no .vhd
extension and adds it. This needs to be fixed. We were seeing some marvin test
fail on Xenserver due to a additonal .vhd extension. Look at the
test_01_snapshot_root_disk failure for Xen in this PR for example:
https://github.com/apache/cloudstack/pull/1754 and the cause that @serg38
pointed out.
> test_snapshot is failing due to incorrect string construction in utils.py
> -------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9633
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: marvin
> Affects Versions: 4.10.0.0
> Environment: https://github.com/apache/cloudstack/pull/1800
> Reporter: Boris Stoyanov
> Fix For: 4.10.0.0
>
>
> When searching for the snapshot vhd on the nfs storage it adds
> ([name].vhd.vhd) I've removed the extension for xenserver and it passed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
