[
https://issues.apache.org/jira/browse/CLOUDSTACK-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772699#comment-15772699
]
ASF subversion and git services commented on CLOUDSTACK-9676:
-------------------------------------------------------------
Commit 23df5be29e7af2a3a3b0f6c7862933e9addf77b8 in cloudstack's branch
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=23df5be ]
Merge pull request #1828 from sateesh-chodapuneedi/pr-cloudstack-9676
CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot when
there are child VM snapshotsJira
===
CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot when
there are child VM snapshots
Issue
====
Start instance fails after reverting to a VM snapshot, when there is 1 or more
child VM snapshots in the snapshot tree of the VM.
Per the code, the method hasSnapshot() is supposed to detect the presence of
any snapshot for the VM. But we are checking for only current snapshot instead
of checking presence of any snapshot in the snapshot tree.
The failure to detect all snapshots means ACP reconfigures the VM in wrong way
assuming there are no snapshots for the VM.
This results in start failure.
Fix
===
Ensure correct detection of VM snapshots in the VM snapshot tree
* pr/1828:
CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot, when
there are child VM snapshots
Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com>
> Start instance fails after reverting to a VM snapshot, when there are child
> VM snapshots
> ----------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9676
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9676
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Affects Versions: 4.9.0.1
> Environment: vSphere 5.5
> ACS master commit 17653a86fad67447a4f13e455e336694ad5c1735
> Reporter: Sateesh Chodapuneedi
> Assignee: Sateesh Chodapuneedi
> Priority: Critical
> Fix For: 4.10.0.0
>
>
> Start instance fails after reverting to a VM snapshot, when there is 1 or
> more child VM snapshots in the snapshot tree of the VM.
> Per the code that detects the presence of a snapshot, we are checking for
> only current snapshot instead of checking presence of any snapshot in the
> snapshot tree. The failure to detect all snapshots means ACP reconfigures the
> VM in wrong way assuming there are no snapshots for the VM. This results in
> start failure.
> {code:borderStyle=solid}
> public boolean hasSnapshot() throws Exception {
> VirtualMachineSnapshotInfo info = getSnapshotInfo();
> if (info != null) {
> return info.getCurrentSnapshot() != null;
> }
> return false;
> }
> {code}
> Steps to reproduce
> ===============
> # Prepare setup with esxi5.5
> # Deploy a vm and create three snapshot i1,i2,i3.
> # Delete i2. and stop vm
> # Revert vm to i1
> # Delete i1
> # Start vm
> Start vm is failing with error,
> {noformat}
> StartCommand failed due to Exception: java.lang.RuntimeException Message:
> Invalid configuration for device '0'.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
