[
https://issues.apache.org/jira/browse/CLOUDSTACK-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787381#comment-15787381
]
ASF GitHub Bot commented on CLOUDSTACK-9698:
--------------------------------------------
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1861#discussion_r94216151
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -123,12 +125,14 @@
import com.cloud.utils.ssh.SshHelper;
import com.cloud.vm.DomainRouterVO;
-public class VmwareManagerImpl extends ManagerBase implements
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService {
+public class VmwareManagerImpl extends ManagerBase implements
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService,
Configurable {
private static final Logger s_logger =
Logger.getLogger(VmwareManagerImpl.class);
private static final int STARTUP_DELAY = 60000; // 60
seconds
private static final long DEFAULT_HOST_SCAN_INTERVAL = 600000; //
every 10 minutes
+ public static final ConfigKey<Long> s_vmwareNicHotplugWaitTimeout =
new ConfigKey<Long>("Advanced", Long.class, "vmware.nic.hotplug.wait.timeout",
"20000",
--- End diff --
Yes, preivously it was intended, as this is just timeout value in cases
that need more time for hotplug device detection and doesn't introduce delay in
regular scenarios.
But left it as 15000, just keep the default behavior intact. If require
admin may modify the configuration parameter per their environment's
requirements. Pushed the updated code change.
> Make the wait timeout for NIC adapter hotplug as configurable
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-9698
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9698
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Affects Versions: 4.9.0.1
> Environment: ACS 4.9 branch commit
> a0e36b73aebe43bfe6bec3ef8f53e8cb99ecbc32
> vSphere 5.5
> Reporter: Sateesh Chodapuneedi
> Assignee: Sateesh Chodapuneedi
> Fix For: 4.9.1.0
>
>
> Currently ACS waits for 15 seconds (*hard coded*) for hot-plugged NIC in VR
> to get detected by guest OS. The time taken to detect hot plugged NIC in
> guest OS depends on type of NIC adapter like (E1000, VMXNET3, E1000e etc.)
> and guest OS itself. In uncommon scenarios the NIC detection may take longer
> time than 15 seconds, in such cases NIC hotplug would be treated as failure
> which results in VPC tier configuration failure. Making the wait timeout for
> NIC adapter hotplug as configurable will be helpful for admins in such
> scenarios.
> Also in future if VMware introduces new NIC adapter types which may take time
> to get detected by guest OS, it is good to have flexibility of configuring
> the wait timeout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
