[
https://issues.apache.org/jira/browse/CLOUDSTACK-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15789242#comment-15789242
]
ASF GitHub Bot commented on CLOUDSTACK-8672:
--------------------------------------------
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1859#discussion_r94271338
--- Diff:
plugins/network-elements/netscaler/src/com/cloud/network/vm/NetScalerVMManager.java
---
@@ -0,0 +1,86 @@
+//Licensed to the Apache Software Foundation (ASF) under one
+//or more contributor license agreements. See the NOTICE file
+//distributed with this work for additional information
+//regarding copyright ownership. The ASF licenses this file
+//to you under the Apache License, Version 2.0 (the
+//"License"); you may not use this file except in compliance
+//with the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+//Unless required by applicable law or agreed to in writing,
+//software distributed under the License is distributed on an
+//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+//KIND, either express or implied. See the License for the
+//specific language governing permissions and limitations
+//under the License.
+package com.cloud.network.vm;
+import java.util.Map;
+
+import com.cloud.api.commands.DeployNetscalerVpxCmd;
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.router.VirtualRouter;
+import com.cloud.user.Account;
+
+public interface NetScalerVMManager {
+
+//RAM/CPU for the system offering used by Internal LB VMs
+ public static final int DEFAULT_NETSCALER_VM_RAMSIZE = 2048;
// 2048 MB
+ public static final int DEFAULT_NETSCALER_VM_CPU_MHZ = 1024;
// 1024 MHz
+
+/* *//**
+ * Destroys Internal LB vm instance
+ * @param vmId
+ * @param caller
+ * @param callerUserId
+ * @return
+ * @throws ResourceUnavailableException
+ * @throws ConcurrentOperationException
+ *//*
+ boolean destroyInternalLbVm(long vmId, Account caller, Long callerUserId)
throws ResourceUnavailableException, ConcurrentOperationException;
+
+ *//**
+ * Deploys internal lb vm
+ * @param guestNetwork
+ * @param requestedGuestIp
+ * @param dest
+ * @param owner
+ * @param params
+ * @return
+ * @throws InsufficientCapacityException
+ * @throws ConcurrentOperationException
+ * @throws ResourceUnavailableException
+ *//*
+ List<? extends VirtualRouter> deployInternalLbVm(Network guestNetwork, Ip
requestedGuestIp, DeployDestination dest, Account owner, Map<Param, Object>
params)
+ throws InsufficientCapacityException, ConcurrentOperationException,
ResourceUnavailableException;
+
+ *//**
+ *
+ * @param network
+ * @param rules
+ * @param internalLbVms
+ * @return
+ * @throws ResourceUnavailableException
+ *//*
+ boolean applyLoadBalancingRules(Network network, List<LoadBalancingRule>
rules, List<? extends VirtualRouter> internalLbVms) throws
ResourceUnavailableException;
+
+ *//**
+ * Returns existing Internal Load Balancer elements based on
guestNetworkId (required) and requestedIp (optional)
+ * @param guestNetworkId
+ * @param requestedGuestIp
+ * @return
+ *//*
+ List<? extends VirtualRouter> findInternalLbVms(long guestNetworkId, Ip
requestedGuestIp);
+*/
+
+ public Map<String, Object> deployNetscalerServiceVm(DeployNetscalerVpxCmd
cmd);
+
+ public VirtualRouter stopNetscalerServiceVm(Long id, boolean forced,
Account callingAccount, long callingUserId) throws
ConcurrentOperationException, ResourceUnavailableException;
+ public Map<String, Object> deployNsVpx(Account owner, DeployDestination
dest, DeploymentPlan plan, long svcOffId, long templateId) throws
InsufficientCapacityException;
+
+public VirtualRouter stopNetScalerVm(Long id, boolean forced, Account
callingAccount, long callingUserId);
+}
--- End diff --
@rajesh-battala : There is no such character. It just says there is no new
line at the end of the file.
> NCC Integration with CloudStack
> -------------------------------
>
> Key: CLOUDSTACK-8672
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8672
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Devices
> Affects Versions: 4.6.0
> Reporter: Rajesh Battala
> Assignee: Rajesh Battala
> Priority: Critical
> Fix For: Future
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
