[
https://issues.apache.org/jira/browse/CLOUDSTACK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802839#comment-15802839
]
ASF GitHub Bot commented on CLOUDSTACK-9730:
--------------------------------------------
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1891
CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to
existing VMware cluster
Issue: Unable to add a host with space in its name to existing VMware
cluster
Root Cause: Previously cluster url from API used to be inserted into DB
after validation of inventory url. White spaces in url would be encoded as '+'
during creation of URI object which are being inserted into database. Further
references of the cluster's data center name would see '+' symbols instead of
white space which is incorrect.
Fix: Skip update of encoded cluster url path in cluster_details table while
adding host to existing cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9730
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1891.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1891
----
commit 9b5b3aa30a04589be843c66dd8173a2b94a92d4d
Author: Suresh Kumar Anaparti <[email protected]>
Date: 2017-01-05T23:12:14Z
CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to
Cluster
Skip update of encoded cluster url path in cluster_details table while
adding host to existing cluster.
Previously cluster url from API used to be inserted into DB after
validation of inventory url. White spaces in url would be encoded as '+' during
creation of URI object which are being inserted into database. Further
references of the cluster's data center name would see '+' symbols instead of
white space which is incorrect.
----
> [VMware] Unable to add a host with space in its name to existing VMware
> cluster
> -------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9730
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9730
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Reporter: Suresh Kumar Anaparti
> Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> ISSUE
> ==================
> Unable to add a host with space in the name to existing VMware cluster.
> While adding host, CloudStack tries to persist the validated inventory url
> path in database, which inserts encoded url into database which means
> whitespace would be stored as '+' symbols. Url from API parameter string is
> being converted to URI object as part of validation, where the url path is
> getting encoded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
