[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806042#comment-15806042
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9699:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1884#discussion_r95033188
  
    --- Diff: test/integration/smoke/test_global_settings.py ---
    @@ -63,6 +63,33 @@ def test_UpdateConfigParamWithScope(self):
             self.assertEqual(configParam.value, 
updateConfigurationResponse.value, "Check if the update API returned \
                              is the same as the one we got in the list API")
     
    +    @attr(tags=["devcloud", "basic", "advanced"], 
required_hardware="false")
    +    def test_list_capabilities(self):
    +        """
    +        @summary: Test List Capabilities
    +        @Steps
    +        Step1: Listing all the Capabilities for a user
    +        Step2: Verifying the listcapabilities object is not null
    +        Step3: Verifying enable.metrics.ui is not null
    +        """
    +        # Listing all the Capabilities for a user
    +
    +        listCapabilities = Configurations.listCapabilities(self.apiClient)
    +        # Verifying the listcapabilities object is not null
    +        self.assertIsNotNone(
    +                listCapabilities,
    +                "Failed to list Capabilities"
    +        )
    +
    +        # Verifying enable.metrics.ui is not null
    +        self.assertIsNotNone(
    +                listCapabilities.enablemetricsui,
    +                "Failed to fetch enable.metrics.ui"
    +        )
    --- End diff --
    
    Please add tests to verify that the value is set as expected.


> Metrics: Add a global setting to enable/disable Metrics view
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9699
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9699
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: UI
>    Affects Versions: 4.7.0, 4.8.0, 4.9.0
>            Reporter: Rashmi Dixit
>            Assignee: Rashmi Dixit
>             Fix For: 4.10.0.0
>
>         Attachments: enable-metrics-flag.PNG, metrics-disabled.PNG, 
> metrics-enabled.PNG
>
>
> The Metrics view for each type of entity basically fires APIs and calculates 
> required values on the client end. For e.g. to display memory usage etc at 
> the zone level, it will fetch all zones. For each zone it will fetch 
> pods->cluster->host->VMs
> For a very large Cloudstack installation this will have a major impact on the 
> performance. 
> Ideally, there should be an API which calculates all this in the backend and 
> the UI should simply show the values. However, for the time, introduce a 
> global setting called enable.metrics which will be set to false. This will 
> cause the metrics button not to be shown on any of the pages.
> If the Admin changes this to true, then the button will be visible and 
> Metrics functionality will work as usual.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to