[
https://issues.apache.org/jira/browse/CLOUDSTACK-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825751#comment-15825751
]
ASF GitHub Bot commented on CLOUDSTACK-9317:
--------------------------------------------
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1908
CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface
FIxed issue in disabling multiple static nat simultaneously.
This patch has taken changes from the PR 1450 and added the missing parts
https://github.com/apache/cloudstack/pull/1450
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accelerite/cloudstack staticnat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1908
----
commit 7e9c436c904dd7e21844aa34177854eda42a82ee
Author: Jayapal <jayapal.ur...@accelerite.com>
Date: 2017-01-17T09:50:16Z
CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface
----
> Disabling static NAT on many IPs can leave wrong IPs on the router
> ------------------------------------------------------------------
>
> Key: CLOUDSTACK-9317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9317
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, Virtual Router
> Affects Versions: 4.7.0, 4.7.1, 4.7.2
> Reporter: Jeff Hair
>
> The current behavior of enabling or disabling static NAT will call the apply
> IP associations method in the management server. The method is not
> thread-safe. If it's called from multiple threads, each thread will load up
> the list of public IPs in different states (add or revoke)--correct for the
> thread, but not correct overall. Depending on execution order on the virtual
> router, the router can end up with public IPs assigned to it that are not
> supposed to be on it anymore. When another account acquires the same IP, this
> of course leads to network problems.
> The problem has been in CS since at least 4.2, and likely affects all
> recently released versions. Affected version is set to 4.7.x because that's
> what we verified against.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
