[jira] (CLOUDSTACK-9752) [Vmware] Optimization of volume attachness to vm

[ASF GitHub Bot (JIRA)]

Title: Message Title

ASF GitHub Bot commented on CLOUDSTACK-9752   Re: [Vmware] Optimization of volume attachness to vm Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1913#discussion_r98365757 — Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java — @@ -1577,9 +1577,6 @@ public Answer createVolume(CreateObjectCommand cmd) { } synchronized (this) { // s_logger.info("Delete file if exists in datastore to clear the way for creating the volume. file: " + volumeDatastorePath); VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), dcMo); - vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L * 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey()); vmMo.detachDisk(volumeDatastorePath, false); End diff – Is there a possibility that `detachDisk` might fail? In that case, we would require the above check to be performed as Cloudstack would retry the operation. Same in the `finally` clause Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)