[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859354#comment-15859354
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9743:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
  
    --- Diff: 
plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java
 ---
    @@ -156,7 +153,7 @@ public HostVO createHostVOForDirectConnectAgent(HostVO 
host, StartupCommand[] st
     
         @Override
         public DeleteHostAnswer deleteHost(HostVO host, boolean isForced, 
boolean isForceDeleteStorage) throws UnableDeleteHostException {
    -        return new DeleteHostAnswer(true);
    +        return null;
    --- End diff --
    
    @syed I am not sure if this is used or maintained by anyone. But the right 
fix may be to use some checks to return a valid answer or null. How is this 
handled in some of the other network elements?


> ODL plugin responds to deleteHost causing other plugin in the chain to be 
> ignored
> ---------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9743
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9743
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: cloudstack-agent, Network Controller
>            Reporter: Syed Ahmed
>
> ODL plugin responds to deleteHost causing other plugin in the chain to be 
> ignored



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to