[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862414#comment-15862414
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9780:
--------------------------------------------

Github user swill commented on the issue:

    https://github.com/apache/cloudstack/pull/1938
  
    @ustcweizhou I am not comfortable with that change. If more than one java 
is installed and Java 8 is not the default, then this will incorrectly set 
java_home (if I understand correctly). 
    
    I will leave my pr as is. It solves the problem the same way it was done in 
the past. If you would like to introduce a new approach and test it against the 
different distributions, please open a new PR with your new implementation. 


> Default to Java8 if JAVA_HOME is not set
> ----------------------------------------
>
>                 Key: CLOUDSTACK-9780
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9780
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.10.0.0
>            Reporter: Will Stevens
>
> Now that PR1888 is merged, Java8 is required.  Unfortunately the file pushed 
> to `/etc/cloudstack/management/classpath.conf` will default to Java7 if the 
> JAVA_HOME is not set.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to