ASF GitHub Bot commented on CLOUDSTACK-9611:

Github user nitin-maharana commented on a diff in the pull request:

    --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
    @@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
             // Verify account is valid
             Account vlanOwner = null;
             if (projectId != null) {
    -            if (accountName != null) {
    -                throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
    -            }
    +            //accountName and projectId are mutually exclusive
    --- End diff --
    @koushik-das : As I mentioned in resolution part, Even if the account name 
is passed while adding from a particular project view, then it is 
ignored(Removal part) in API. If we don't remove that validation check, then 
the same issue will happen again. 

> Dedicating a Guest VLAN range to Project does not work
> ------------------------------------------------------
>                 Key: CLOUDSTACK-9611
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9611
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitin Kumar Maharana
> Trying to dedicate a guest VLAN range to an account fails. If we pass both 
> account and projectid parameters to the dedicateGuestVlanRange (which are not 
> mentioned as mutually exclusive in API description) the API layer throws 
> error saying both are mutually exclusive.
> Steps to Reproduce:
> ================
> Create an account. Create a project in that account.
> Go to admin account and change view to the above project.
> Navigate to Infrastructure -> Zone -> Physical Network -> Guest -> Dedicate 
> Guest VLAN range.
> Try to dedicate the guest VLAN range from the project view for the account 
> associated with the project.
> It fails with Error saying accountName and projectId are mutually exclusive.
> Expected:
> ========
> The VLAN range should get dedicated to the project account.
> Notes:
> =====
> If we do the dedication from default view then it works fine as no projectid 
> is associated over there.

This message was sent by Atlassian JIRA

Reply via email to