[ https://issues.apache.org/jira/browse/CLOUDSTACK-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872484#comment-15872484 ]
ASF GitHub Bot commented on CLOUDSTACK-9746: -------------------------------------------- Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1915 @ustcweizhou - Thanks for the +1 on cron.hourly move. From looking at the code, it looks like non-redundant VRs are already moving to cron.hourly, but vpcrouter isn't. In our case, we are using vpcrouter. I'm working on a PR against master that will fix the vpcrouter flavor of this code. I'll link the PR here when I'm done testing. I'd also like to understand why you would prefer 'size' over 'maxsize'. I know the difference is subtle and it really won't apply to anything that is set to "hourly", but it could impact the dailys. In the VR case with a limited /var/log partition size, I would think that the 'maxsize' option would be preferable. It would keep run away log files in check by rotating them even before their interval is reached. ```size size Log files are rotated only if they grow bigger then size bytes. If size is followed by k, the size is assumed to be in kilo- bytes. If the M is used, the size is in megabytes, and if G is used, the size is in gigabytes. So size 100, size 100k, size 100M and size 100G are all valid. maxsize size Log files are rotated when they grow bigger than size bytes even before the additionally specified time interval (daily, weekly, monthly, or yearly). The related size option is similar except that it is mutually exclusive with the time interval options, and it causes log files to be rotated without regard for the last rotation time. When maxsize is used, both the size and timestamp of a log file are considered. ``` > system-vm: logrotate config causes critical failures > ---------------------------------------------------- > > Key: CLOUDSTACK-9746 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9746 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: SystemVM > Affects Versions: 4.8.0, 4.9.0 > Reporter: Joakim Sernbrant > Priority: Critical > > CLOUDSTACK-6885 changed logrotate from time based to size based. This means > that logs will grow up to its size times two (due to delaycompress). > For example: > 50M auth.log > 50M auth.log.1 > 10M cloud.log > 10M cloud.log.1 > 50M cron.log > 50M cron.log.1 > 50M messages > 50M messages.1 > ... > Some files will grow slowly but eventually they will get to their max size. > The total allowed log size with the current config is well beyond the size of > the log partition. > Having a full /dev/log puts the VR in a state where operations on it > critically fails. -- This message was sent by Atlassian JIRA (v6.3.15#6346)