[
https://issues.apache.org/jira/browse/CLOUDSTACK-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878183#comment-15878183
]
ASF GitHub Bot commented on CLOUDSTACK-9793:
--------------------------------------------
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1948
Great, nice work.
LGTM
> Unnecessary conversion from IPNetwork to list causes router slowdown when
> processing static Nat rules
> -----------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9793
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9793
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.7.0, 4.8.0, 4.9.0
> Reporter: Stefania Bergljot Stefansdottir
> Fix For: 4.10.0.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In the CsInterface class in CsAddress.py on the virtual router there's a
> function
> {code:java}
> def ip_in_subnet(self, ip):
> ipo = IPAddress(ip)
> net = IPNetwork("%s/%s" % (self.get_ip(), self.get_size()))
> return ipo in list(net)
> {code}
> Skipping the list conversion and using "return ipo in net" is much faster and
> the functionality is the same. It can prevent a router timeout when attaching
> or detaching multiple IPs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
