[ https://issues.apache.org/jira/browse/CLOUDSTACK-9723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880009#comment-15880009 ]
ASF GitHub Bot commented on CLOUDSTACK-9723: -------------------------------------------- Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102649918 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -83,9 +83,19 @@ public final static int DEFAULT_AUTOSCALE_POLICY_INTERVAL_TIME = 30; public final static int DEFAULT_AUTOSCALE_POLICY_QUIET_TIME = 5 * 60; private final static Random s_rand = new Random(System.currentTimeMillis()); - - public static long createSequenceBasedMacAddress(final long macAddress) { - return macAddress | 0x060000000000l | (long)s_rand.nextInt(32768) << 25 & 0x00fffe000000l; + private final static long prefix = 0x1e; + + public static long createSequenceBasedMacAddress(final long macAddress, long globalConfig) { --- End diff -- It is not possible for macAddress, globalConfig to less than zero. For globalconfig maximum value 255 is allowed. macAddress value is coming from the DB (ipVO) > Enable unique mac address across different deployments and networks > ------------------------------------------------------------------- > > Key: CLOUDSTACK-9723 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9723 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Jayapal Reddy > Assignee: Jayapal Reddy > Fix For: 4.10.0.0 > > > Specify the MAC address range for VMs created in ACS > If there are Multiple CCP environments, There is difficulty in identifying > VMs based on their MAC addresses since the addresses are duplicated across > environments. > Specifying the MAC address range in zone will avoid the conflict. -- This message was sent by Atlassian JIRA (v6.3.15#6346)