[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880252#comment-15880252
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8239:
--------------------------------------------

Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1955#discussion_r102687170
  
    --- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
    @@ -2216,6 +2225,8 @@ public int compare(final DiskTO arg0, final DiskTO 
arg1) {
                         
disk.setCacheMode(DiskDef.DiskCacheMode.valueOf(volumeObjectTO.getCacheMode().toString().toUpperCase()));
                     }
                 }
    +
    +            s_logger.debug("Adding disk: " + disk.toString());
    --- End diff --
    
    Same here, please include the name of the VM
    
    Also, do we really need all these logging lines?


> Add support for VirtIO-SCSI for KVM hypervisors
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-8239
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8239
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: KVM, Storage Controller
>    Affects Versions: 4.6.0
>         Environment: KVM
>            Reporter: Andrei Mikhailovsky
>            Assignee: Wido den Hollander
>            Priority: Critical
>              Labels: ceph, gsoc2017, kvm, libvirt, rbd, storage_drivers, 
> virtio
>             Fix For: Future
>
>
> It would be nice to have support for virtio-scsi for KVM hypervisors.
> The reason for using virtio-scsi instead of virtio-blk would be increasing 
> the number of devices you can attach to a vm, have ability to use discard and 
> reclaim unused blocks from the backend storage like ceph rbd. There are also 
> talks about having a greater performance advantage as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to