[
https://issues.apache.org/jira/browse/CLOUDSTACK-8663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880591#comment-15880591
]
ASF GitHub Bot commented on CLOUDSTACK-8663:
--------------------------------------------
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1941#discussion_r102730127
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1415,6 +1417,10 @@ public VM createWorkingVM(final Connection conn,
final String vmName, final Stri
vbdr.userdevice = "autodetect";
vbdr.mode = Types.VbdMode.RW;
vbdr.type = Types.VbdType.DISK;
+ Long deviceId = volumeTO.getDeviceId();
+ if (deviceId != null && (!isDeviceUsed(conn, vm, deviceId) ||
deviceId > 3)) {
--- End diff --
There is this one also https://github.com/apache/cloudstack/pull/1829.
However, after sorting out the tests failures and with the code approved I
don't think that this would be a reason to not take the PR forward.
> Snapshot Improvements
> ---------------------
>
> Key: CLOUDSTACK-8663
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8663
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
> Fix For: Future
>
>
> Split volume snapshot process
> Allow VM snapshot and volume snapshots to exist together
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
