[
https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880636#comment-15880636
]
ASF GitHub Bot commented on CLOUDSTACK-9748:
--------------------------------------------
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1957
Actually, my concerns are not regarding the response. Reading the name of
the method one can for sure understand what it returns. My concern is that
reading the parameter name `keyword` I really have no clue that this keyword is
part of a username. The `keyword` could be used to list users of domains that
may match it; the same can be applied for projects. Did you understand what I
mean?
I was trying to discuss if we could find a better way to document it. As
you also checked, there are other methods that this situation happens. However,
I really do not believe this is a good standard to follow.
Would not something like the following work as well?
```
...
sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), Op.IN);
sb.and().op("username", sb.entity().getUsername(),
SearchCriteria.Op.EQ).or("username", "%" + sb.entity().getUsername() + "%" ,
SearchCriteria.Op.LIKE);
...
```
> VPN Users search functionality broken
> -------------------------------------
>
> Key: CLOUDSTACK-9748
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Reporter: Ashadeepa Debnath
>
> VPN Users search functionality broken
> If you try to search VPN users with it’s user name, you will not be able to
> search.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
