[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885235#comment-15885235
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9783:
--------------------------------------------

Github user marcaurele commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1944#discussion_r103143033
  
    --- Diff: plugins/metrics/pom.xml ---
    @@ -0,0 +1,55 @@
    +<!--
    +  Licensed to the Apache Software Foundation (ASF) under one
    +  or more contributor license agreements. See the NOTICE file
    +  distributed with this work for additional information
    +  regarding copyright ownership. The ASF licenses this file
    +  to you under the Apache License, Version 2.0 (the
    +  "License"); you may not use this file except in compliance
    +  with the License. You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing,
    +  software distributed under the License is distributed on an
    +  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  KIND, either express or implied. See the License for the
    +  specific language governing permissions and limitations
    +  under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
    +  http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +  <modelVersion>4.0.0</modelVersion>
    +  <artifactId>cloud-plugin-metrics</artifactId>
    +  <name>Apache CloudStack Plugin - Metrics</name>
    +  <parent>
    +    <groupId>org.apache.cloudstack</groupId>
    +    <artifactId>cloudstack-plugins</artifactId>
    +    <version>4.9.3.0-SNAPSHOT</version>
    +    <relativePath>../pom.xml</relativePath>
    +  </parent>
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.cloudstack</groupId>
    +      <artifactId>cloud-api</artifactId>
    +      <version>${project.version}</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.cloudstack</groupId>
    +      <artifactId>cloud-utils</artifactId>
    +      <version>${project.version}</version>
    +    </dependency>
    +  </dependencies>
    +  <build>
    +    <plugins>
    --- End diff --
    
    Would be nice to follow maven standards on new modules. Since you cannot 
inherit from `cloud-maven-standard` you have to put all those lines:
    ```
    <build>
        <sourceDirectory>${basedir}/src/main/java</sourceDirectory>
        
<scriptSourceDirectory>${basedir}/src/main/scripts</scriptSourceDirectory>
        <testSourceDirectory>${basedir}/src/test/java</testSourceDirectory>
        <outputDirectory>${basedir}/target/classes</outputDirectory>
        
<testOutputDirectory>${basedir}/target/test-classes</testOutputDirectory>
        <resources>
          <resource>
            <directory>${basedir}/src/main/resources</directory>
          </resource>
        </resources>
        <testResources>
          <testResource>
            <directory>${basedir}/src/test/resources</directory>
          </testResource>
        </testResources>
        ...
    </build>
    ```


> Improve metrics view performance
> --------------------------------
>
>                 Key: CLOUDSTACK-9783
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.10.0.0, 4.9.3.0
>
>
> Metrics view is a pure frontend feature, where several API calls are made to 
> generate the metrics view tabular data. In very large environments, rendering 
> of these tables can take a lot of time, especially when there is high 
> latency. The improvement task is to reimplement this feature by moving the 
> logic to backend so metrics calculations happen at the backend and final 
> result can be served by a single API request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to