[
https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887764#comment-15887764
]
ASF GitHub Bot commented on CLOUDSTACK-9104:
--------------------------------------------
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r103423690
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
return new String[] {datastoreDiskPath};
}
- // Pair<internal CS name, vCenter display name>
- private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
- String vmInternalCSName = vmSpec.getName();
- String vmNameOnVcenter = vmSpec.getName();
- if (_instanceNameFlag && vmSpec.getHostName() != null) {
- vmNameOnVcenter = vmSpec.getHostName();
+ /**
+ * This method generates VM name for Vcenter and Cloudstack( when
Hypervisor is VMware).
+ * It generates VM name according to _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ * vmSpec
+ * @return Pair<internal CS name, vCenter display name>. A pair which
contain 'internal CS name' and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+ protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec)
{
+
+ String vmInternalCSName = "";
+ String vmNameOnVcenter = "";
+ if(vmSpec != null)
+ {
+ vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+ if (_instanceNameFlag == true && vmSpec.getType() ==
VirtualMachine.Type.User) {
+ String[] tokens = vmInternalCSName.split("-");
+ if(tokens.length<3) throw new
InvalidParameterValueException("Invalid vmInternalCSName format:
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); //
vmInternalCSName has format i-x-y-<instance.name>
+ vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0],
tokens[1], tokens[2], vmSpec.getHostName());
--- End diff --
@sateesh-chodapuneedi what is your opinion ?
> VM naming convention in case vmware is used
> -------------------------------------------
>
> Key: CLOUDSTACK-9104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Priyank Parihar
> Assignee: Priyank Parihar
>
> ISSUE
> ======
> VM naming convention in case vmware is used.
> Description
> ==========
> User with different account cannot create VMs with the same name, which was
> possible earlier (I am not sure in which CCP version). That time naming
> convention used was like this “I-<user-id>-<Display-Name>”
> Currently if vm.instancename.flag is set to true the VM name will be exactly
> as display name given.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
