[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894319#comment-15894319
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9704:
--------------------------------------------

Github user sateesh-chodapuneedi commented on the issue:

    https://github.com/apache/cloudstack/pull/1862
  
    Thanks @borisstoyanov 
    
    The 3 test failures listed in results doesn't seem related to the code 
changes in PR. 
    
    ```
    2017-03-02 17:45:11,699 - CRITICAL - EXCEPTION: 
test_02_list_snapshots_with_removed_data_store: ['Traceback (most recent call 
last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n  
  testMethod()\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py", line 30, 
in test_wrapper\n    return test(self, *args, **kwargs)\n', '  File 
"/marvin/tests/smoke/test_snapshots.py", line 363, in 
test_02_list_snapshots_with_removed_data_store\n    id=snapshot.id\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1125, in list\n    
return(apiclient.listSnapshots(cmd))\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1161, in listSnapshots\n    response = 
self.connection.marvinRequest(command, response_type=response, 
method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\n    raise e\n', 'CloudstackAPIException: Execute cmd: 
listsnapshots failed, due to: errorCode: 530, errorText:Unable to locate 
datastore with id 5\n']
    
    2017-03-02 17:45:16,772 - CRITICAL - EXCEPTION: 
test_02_list_snapshots_with_removed_data_store: ['Traceback (most recent call 
last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 398, in run\n  
  self.tearDown()\n', '  File "/marvin/tests/smoke/test_snapshots.py", line 
174, in tearDown\n    raise Exception("Warning: Exception during cleanup : %s" 
% e)\n', "Exception: Warning: Exception during cleanup : Job failed: 
{jobprocstatus : 0, created : u'2017-03-02T17:45:13+0000', jobresult : 
{errorcode : 431, errortext : u'Unable to find a virtual machine with specified 
vmId'}, cmd : 
u'org.apache.cloudstack.api.command.admin.vm.DestroyVMCmdByAdmin', userid : 
u'87233b2e-ff35-11e6-be08-06674c01070f', jobstatus : 2, jobid : 
u'43f0ee45-e763-45bc-b777-795c7eaeb26a', jobresultcode : 530, jobinstanceid : 
u'3be27ffe-1884-493b-9566-e616cf2d85d0', jobresulttype : u'object', 
jobinstancetype : u'VirtualMachine', accountid : 
u'872334ae-ff35-11e6-be08-06674c01070f'}\n"]
    
    2017-03-02 17:45:41,985 - CRITICAL - EXCEPTION: 
test_02_list_snapshots_with_removed_data_store: ['Traceback (most recent call 
last):\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 228, 
in run\n    self.tearDown()\n', '  File 
"/usr/lib/python2.7/site-packages/nose/suite.py", line 351, in tearDown\n    
self.teardownContext(ancestor)\n', '  File 
"/usr/lib/python2.7/site-packages/nose/suite.py", line 367, in 
teardownContext\n    try_run(context, names)\n', '  File 
"/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run\n    
return func()\n', '  File "/marvin/tests/smoke/test_snapshots.py", line 160, in 
tearDownClass\n    raise Exception("Warning: Exception during cleanup : %s" % 
e)\n', "Exception: Warning: Exception during cleanup : Job failed: 
{jobprocstatus : 0, created : u'2017-03-02T17:45:39+0000', jobresult : 
{errorcode : 530, errortext : u'Failed to delete template'}, cmd : 
u'org.apache.cloudstack.api.command.user.template.DeleteTemplateCmd', userid : 
u'87233b2e-ff35-11e6-be08-06674c01070f', jobstatus : 2, jobid : 
u'df91fb7f-b9fd-4b9f-8d07-654821c42d69', jobresultcode : 530, jobinstanceid : 
u'5fc32822-46b8-43e9-ac33-8ad5bb00e775', jobresulttype : u'object', 
jobinstancetype : u'Template', accountid : 
u'872334ae-ff35-11e6-be08-06674c01070f'}\n"]
    
    ```


> Remove dependency on VmwareContext object to fetch system VM key file
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9704
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9704
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>
> While remote executing commands/scripts in VR, ACS uses system vm keyfile. 
> ACS is fetching this key file using following code
> {code:java}
> VmwareManager mgr = 
> getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
> File systemVmKeyFile = mgr.getSystemVMKeyFile();
> {code}
> This is inefficient because dependency on getServiceContext() in above code 
> means a vCenter connection handle which is not required just to fetch a file 
> in name space in management server.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to