[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924008#comment-15924008
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------

Github user bvbharatk commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r105881440
  
    --- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 ---
    @@ -512,7 +512,11 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
             });
             HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
     
    -        _agentMgr.reconnect(host.getId());
    +        try {
    +            _agentMgr.reconnect(host.getId());
    +        } catch (Exception e ) {
    --- End diff --
    
    Using a more specific catch makes sense, I will take this up in a separate 
PR. This was supposed to be a small improvement to the existing code.


> Improve Error Message for Host Alert State
> ------------------------------------------
>
>                 Key: CLOUDSTACK-8855
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to