[ https://issues.apache.org/jira/browse/CLOUDSTACK-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932305#comment-15932305 ]
ASF GitHub Bot commented on CLOUDSTACK-9369: -------------------------------------------- Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2009#discussion_r106849093 --- Diff: server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java --- @@ -166,7 +166,7 @@ public String authenticate(String command, Map<String, Object[]> params, HttpSes throw new CloudAuthenticationException("Unable to find the domain from the path " + domain); } final UserAccount userAccount = _accountService.getActiveUserAccount(username[0], domainId); - if (userAccount == null || !(User.Source.UNKNOWN.equals(userAccount.getSource()) || User.Source.LDAP.equals(userAccount.getSource()))) { + if (userAccount != null && User.Source.SAML2 == userAccount.getSource()) { --- End diff -- Why do we need to remove the check `userAccount == null`? Comparision against Source.SAML2 is fine as long as there are no other user sources other than LDAP, SAML2 and UNKNOWN. (UNKNOWN should be NATIVE though) > Security issue! Local login open with SAML implementation > --------------------------------------------------------- > > Key: CLOUDSTACK-9369 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9369 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: SAML > Affects Versions: 4.5.2, 4.6.2, 4.7.1, 4.8.0 > Environment: ACS 4.5.2 > XS 6.2/6.5 > Reporter: Cyrano Rizzo > Assignee: Rajani Karuturi > Priority: Critical > Labels: login, loginmodule, saml > Attachments: > 4.5-CLOUDSTACK-9369-Restrict-default-login-to-ldap-nativ.patch, > 4.7plus-CLOUDSTACK-9369-Restrict-default-login-to-ldap-nativ.patch, > master-CLOUDSTACK-9369-Restrict-default-login-to-ldap-nativ.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > All SAML enabled accounts can login localy with any password -- This message was sent by Atlassian JIRA (v6.3.15#6346)