ASF GitHub Bot commented on CLOUDSTACK-9317:

Github user ProjectMoon commented on a diff in the pull request:

    --- Diff: 
    @@ -1764,9 +1765,12 @@ protected ExecutionResult 
cleanupNetworkElementCommand(final IpAssocCommand cmd)
                     nicNum = 
    -                if (numOfIps == 1 && !ip.isAdd()) {
    -                    vifHotUnPlug(conn, routerName, ip.getVifMacAddress());
    -                    networkUsage(routerIp, "deleteVif", "eth" + nicNum);
    +                if (lastIp != null && lastIp.equalsIgnoreCase("true") && 
!ip.isAdd()) {
    --- End diff --
    `StringUtils.equalsIgnoreCase` can check both null and the value.

> Disabling static NAT on many IPs can leave wrong IPs on the router
> ------------------------------------------------------------------
>                 Key: CLOUDSTACK-9317
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9317
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server, Virtual Router
>    Affects Versions: 4.7.0, 4.7.1, 4.7.2
>            Reporter: Jeff Hair
> The current behavior of enabling or disabling static NAT will call the apply 
> IP associations method in the management server. The method is not 
> thread-safe. If it's called from multiple threads, each thread will load up 
> the list of public IPs in different states (add or revoke)--correct for the 
> thread, but not correct overall. Depending on execution order on the virtual 
> router, the router can end up with public IPs assigned to it that are not 
> supposed to be on it anymore. When another account acquires the same IP, this 
> of course leads to network problems.
> The problem has been in CS since at least 4.2, and likely affects all 
> recently released versions. Affected version is set to 4.7.x because that's 
> what we verified against.

This message was sent by Atlassian JIRA

Reply via email to