[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937950#comment-15937950
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9843:
--------------------------------------------

GitHub user sudhansu7 opened a pull request:

    https://github.com/apache/cloudstack/pull/2015

    CLOUDSTACK-9843 : Performance improvement of SSHHelper

    A delay of 1 sec has been introduced in SSHHelper Class. This is a fail 
safe code. Removing this will improves the performance of deployVm by 4 sec, 
createFirewallRule by 1 sec and createPortForwardingRule by 1 sec.
    
    We have not faced any issues after removing the delay. This was introduced 
when we were using older version of Trilead library. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-9843

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/2015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2015
    
----
commit 05f1982c19e949e90e47d0afbf3afbdadb845b6b
Author: Sudhansu <[email protected]>
Date:   2017-03-21T10:49:44Z

    CLOUDSTACK-9843 : Performance improvement of deployVirtualMachine, 
createFirewallRule, createPortForwardingRule
    
    Removed 1 sec sleep in SSHHelper.

----


> Performance improvement of deployVirtualMachine, createFirewallRule, 
> createPortForwardingRule
> ---------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9843
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9843
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.10.0.0
>            Reporter: Sudhansu Sahu
>            Assignee: Sudhansu Sahu
>
> A delay of 1 sec has been introduced in SSHHelper Class. This is a fail safe 
> code. Removing this will improves the performance of deployVm by 4 sec, 
> createFirewallRule by 1 sec and createPortForwardingRule by 1 sec.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to