[
https://issues.apache.org/jira/browse/CLOUDSTACK-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951043#comment-15951043
]
ASF GitHub Bot commented on CLOUDSTACK-9647:
--------------------------------------------
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1810#discussion_r109176660
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -280,6 +286,16 @@ public boolean finalizeVirtualMachineProfile(final
VirtualMachineProfile profile
public boolean finalizeCommandsOnStart(final Commands cmds, final
VirtualMachineProfile profile) {
final DomainRouterVO domainRouterVO =
_routerDao.findById(profile.getId());
+ Map<String, String> details = new HashMap<String, String>();
+
+ if(profile.getHypervisorType() ==
Hypervisor.HypervisorType.VMware){
+ HypervisorGuru hvGuru =
_hvGuruMgr.getGuru(profile.getHypervisorType());
+ VirtualMachineTO vmTO = hvGuru.implement(profile);
+ if(vmTO.getDetails() != null){
+ details = vmTO.getDetails();
--- End diff --
Otherwise LGTM.
> NIC adapter type becomes e1000 , even after changing the global parameter
> "vmware.systemvm.nic.device.type" to vmxnet3 for VPC VR
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9647
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9647
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, VMware
> Affects Versions: 4.9.0
> Reporter: Sudhansu Sahu
> Assignee: Sudhansu Sahu
>
> ISSUE
> =====
> NIC adapter type becomes e1000 , even after changing the global parameter
> "vmware.systemvm.nic.device.type" to vmxnet3.
> Description
> =========
> Repro steps:-
> -> Set global parameter "vmware.systemvm.nic.device.type" to vmxnet3.
> -> Created a VPC network and deployed a VM using the same network.
> -> Checked the router details and found that for private network , it was
> showing nic adapter type as VMXNET3 and for other networks (public and guest)
> it was showing as E1000.
> -> Rebooted the VPC network and checked it again, it was same as earlier.
> /vmfs/volumes/94ec1ec2-0df8514b/r-2784-VM # grep virtualDev r-2784-VM.vmx
> pciBridge4.virtualDev = "pcieRootPort"
> pciBridge5.virtualDev = "pcieRootPort"
> pciBridge6.virtualDev = "pcieRootPort"
> pciBridge7.virtualDev = "pcieRootPort"
> scsi0.virtualDev = "lsilogic"
> ethernet0.virtualDev = "vmxnet3"
> ethernet1.virtualDev = "e1000"
> ethernet2.virtualDev = "vmxnet3"
> ethernet3.virtualDev = "vmxnet3"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
