[
https://issues.apache.org/jira/browse/CLOUDSTACK-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958811#comment-15958811
]
ASF GitHub Bot commented on CLOUDSTACK-9864:
--------------------------------------------
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2030#discussion_r110145761
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -128,6 +129,7 @@
public class VmwareManagerImpl extends ManagerBase implements
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService,
Configurable {
private static final Logger s_logger =
Logger.getLogger(VmwareManagerImpl.class);
+ private static final long MILISECONDS_PER_MINUTE = 60000;
--- End diff --
MILI typo MILLISECONDS ..
> cleanup stale worker VMs after job expiry time
> ----------------------------------------------
>
> Key: CLOUDSTACK-9864
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9864
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Reporter: Daan Hoogland
> Assignee: Daan Hoogland
> Labels: vmware, vsphere, workers
>
> In the present code cleaning worker vms after a timeout is disabled, with the
> documented reason that there is no API to query for related tasks in vcenter.
> ACS has an expiry time for jobs and a cancel time for jobs.
> - Jobs that take longer then the expiry time will have their results be be
> neglected.
> - Jobs that are cancelled are forcibly removed after the cancellation expity
> time.
> Any worker remaining after expiry+cancellation will surely be stale and can
> be removed.
> As some administrators may not want this behaviour there will be a setting
> which by default is false that will guard against cleaning stale worker VMs.
> Stale worker VMs will be cleaned after 2 * (expiry-time + cancellation-time)
> as a safe margin.
> related settings:
> job.expire.minutes: 1440
> job.cancel.threshold.minutes: 60
> vmware.clean.old.worker.vms: false (new)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
